Skip to content

refactor(migrations): initial framework to build batchable migrations#57396

Closed
devversion wants to merge 3 commits intoangular:mainfrom
devversion:common-infra
Closed

refactor(migrations): initial framework to build batchable migrations#57396
devversion wants to merge 3 commits intoangular:mainfrom
devversion:common-infra

Conversation

@devversion
Copy link
Member

@devversion devversion commented Aug 14, 2024

Introduces a migration framework to build batchable migrations that can run in Large Scale
mode against e.g. all of Google, using workers.

This is the original signal input migration infrastructure extracted into a more generic framework
that we can use for writing additional ones for output, signal queries etc, while making sure those
are not scoped to a single ts.Program that limits them to per-directory execution in very large projects (e.g. G3).

The migration will be updated to use this, and in 1P we will add helpers to easily integrate such
migrations into a Go-based pipeline runner.

credits for the name to @alxhub! 🎉

@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Aug 14, 2024
@devversion devversion requested a review from crisbeto August 14, 2024 16:13
@pullapprove pullapprove bot requested review from alxhub August 14, 2024 16:13
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Aug 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 14, 2024
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Aug 14, 2024
@devversion devversion force-pushed the common-infra branch 2 times, most recently from f81d4b5 to e64aedd Compare August 16, 2024 12:45
@devversion
Copy link
Member Author

devversion commented Aug 16, 2024

Caretaker notes: Please ignore bugged GitHub reviewer on this PR. (Alex). Also, internal BUILD changes needed to land this: https://critique.corp.google.com/cl/663704366

@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 16, 2024
Introduces a migration framework to build batchable migrations that
can run in Large Scale mode against e.g. all of Google, using workers.

This is the original signal input migration infrastructure extracted
into a more generic framework that we can use for writing additional
ones for output, signal queries etc, while making sure those are not
scoped to a single `ts.Program` that limits them to per-directory
execution in very large projects (e.g. G3).

The migration will be updated to use this, and in 1P we will add
helpers to easily integrate such migrations into a Go-based pipeline
runner.
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 16, 2024
@dylhunn dylhunn removed the request for review from alxhub August 17, 2024 13:49
@dylhunn
Copy link
Contributor

dylhunn commented Aug 17, 2024

This PR was merged into the repository by commit 368f36d.

The changes were merged into the following branches: main, 18.2.x

dylhunn pushed a commit that referenced this pull request Aug 17, 2024
Introduces a migration framework to build batchable migrations that
can run in Large Scale mode against e.g. all of Google, using workers.

This is the original signal input migration infrastructure extracted
into a more generic framework that we can use for writing additional
ones for output, signal queries etc, while making sure those are not
scoped to a single `ts.Program` that limits them to per-directory
execution in very large projects (e.g. G3).

The migration will be updated to use this, and in 1P we will add
helpers to easily integrate such migrations into a Go-based pipeline
runner.

PR Close #57396
@dylhunn dylhunn closed this in 368f36d Aug 17, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants