Skip to content

docs(docs-infra): move link tag for correct view#57395

Closed
vladboisa wants to merge 1 commit intoangular:mainfrom
vladboisa:fix_linking
Closed

docs(docs-infra): move link tag for correct view#57395
vladboisa wants to merge 1 commit intoangular:mainfrom
vladboisa:fix_linking

Conversation

@vladboisa
Copy link
Contributor

Move the link tag to the down, for correctly parsing of @link

Fixes #57332

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #57332

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from thePunderWoman August 14, 2024 14:59
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 14, 2024
@ngbot ngbot bot modified the milestone: Backlog Aug 14, 2024
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving the docs!

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 14, 2024
@thePunderWoman
Copy link
Contributor

Caretaker note: this is docs only and is safe to merge without a presubmit

@github-actions
Copy link

Deployed adev-preview for d975b74 to: https://ng-dev-previews-fw--pr-angular-angular-57395-adev-prev-e5u390fo.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Move the link tag to the down, for correctly parsing of '@link'

Fixes angular#57332
@dylhunn
Copy link
Contributor

dylhunn commented Aug 15, 2024

This PR was merged into the repository by commit 9c73943.

The changes were merged into the following branches: main, 18.2.x

@dylhunn dylhunn closed this in 9c73943 Aug 15, 2024
dylhunn pushed a commit that referenced this pull request Aug 15, 2024
Move the link tag to the down, for correctly parsing of '@link'

Fixes #57332

PR Close #57395
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid link

4 participants