refactor(migrations): signal input migration, use input() shorthand and always add readonly modifier#57368
Closed
devversion wants to merge 2 commits intoangular:mainfrom
Closed
refactor(migrations): signal input migration, use input() shorthand and always add readonly modifier#57368devversion wants to merge 2 commits intoangular:mainfrom
input() shorthand and always add readonly modifier#57368devversion wants to merge 2 commits intoangular:mainfrom
Conversation
…gration In some cases, the migration can detect when `input()` as a shorthand may be usable. This commit adds such detection and migrates inputs to this form when possible.
Signal inputs are no longer updated by assignment, unlike `@Input()`, so a good practice is adding `readonly` for the `InputSignal`— which should never be swapped out. This is a safe operation because the migration skips all inputs that are being written anyway.
49fccf7 to
e8df2ea
Compare
devversion
commented
Aug 13, 2024
| protected readonly ImProtected = input(true); | ||
| protected readonly ImProtectedAndReadonly = input(true); | ||
| @CustomDecorator() | ||
| protected readonly usingCustomDecorator = input(true); |
Member
Author
There was a problem hiding this comment.
It didn't feel worth bothering about this formatting here; most code is auto-formatted anyway and doesn't use custom decorators.
crisbeto
approved these changes
Aug 13, 2024
Contributor
|
This PR was merged into the repository by commit 74f0cb7. The changes were merged into the following branches: main, 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits