Skip to content

fix(core): skip hydration for i18n nodes that were not projected #57356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 1 commit into from
Closed

fix(core): skip hydration for i18n nodes that were not projected #57356

AndrewKushnir wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Aug 13, 2024

This commit fixes an issue that happens when an i18n block is defined as a projectable content, but a parent component doesn't project it. With an extra check added in this commit, the code will be taking a regular "creation" pass instead of attempting hydration.

Resolves #57301.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
fix(core): skip hydration for i18n nodes that were not projected
94744ae 
This commit fixes an issue that happens when an i18n block is defined as a projectable content, but a parent component doesn't project it. With an extra check added in this commit, the code will be taking a regular "creation" pass instead of attempting hydration.

Resolves angular#57301.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: hydration labels Aug 13, 2024
@ngbot ngbot bot modified the milestone: Backlog Aug 13, 2024
@AndrewKushnir AndrewKushnir mentioned this pull request Aug 13, 2024
Closed
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Aug 13, 2024

Presubmit.

thePunderWoman
thePunderWoman approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 13, 2024
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Aug 13, 2024

This PR was merged into the repository by commit 84827d5.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir added a commit that referenced this pull request Aug 13, 2024
@AndrewKushnir
fix(core): skip hydration for i18n nodes that were not projected (#57356
de85979 
)

This commit fixes an issue that happens when an i18n block is defined as a projectable content, but a parent component doesn't project it. With an extra check added in this commit, the code will be taking a regular "creation" pass instead of attempting hydration.

Resolves #57301.

PR Close #57356
AndrewKushnir added a commit that referenced this pull request Aug 13, 2024
@AndrewKushnir
fix(core): skip hydration for i18n nodes that were not projected (#57356
822db64 
)

This commit fixes an issue that happens when an i18n block is defined as a projectable content, but a parent component doesn't project it. With an extra check added in this commit, the code will be taking a regular "creation" pass instead of attempting hydration.

Resolves #57301.

PR Close #57356
henry-alakazhang pushed a commit to freelancer/angular that referenced this pull request Aug 30, 2024
@AndrewKushnir @henry-alakazhang
fix(core): skip hydration for i18n nodes that were not projected (ang…
987dcf3 
…ular#57356)

This commit fixes an issue that happens when an i18n block is defined as a projectable content, but a parent component doesn't project it. With an extra check added in this commit, the code will be taking a regular "creation" pass instead of attempting hydration.

Resolves angular#57301.

PR Close angular#57356
This was referenced Sep 4, 2024
Closed
Closed
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 4, 2024
Closed
@alfonsserra alfonsserra mentioned this pull request Sep 5, 2024
Merged
@kidwen kidwen mentioned this pull request Sep 5, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Sep 5, 2024
Open
@JoSSte JoSSte mentioned this pull request Sep 5, 2024
Closed
@soelshaikh soelshaikh mentioned this pull request Sep 6, 2024
Open
@kidwen kidwen mentioned this pull request Sep 7, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Sep 9, 2024
Open
@fjaguado fjaguado mentioned this pull request Sep 9, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: i18n Issues related to localization and internationalization core: hydration target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

i18n on disconnected content-projected nodes breaks hydration

2 participants

@AndrewKushnir @thePunderWoman