Skip to content

refactor(core): Add experimental support to have one event contract w… #57355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iteriani wants to merge 1 commit into from
Closed

refactor(core): Add experimental support to have one event contract w… #57355

iteriani wants to merge 1 commit into from

Conversation

@iteriani
Copy link
Contributor

@iteriani iteriani commented Aug 12, 2024

…hen there are multiple apps on the page.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto August 12, 2024 21:26
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 12, 2024
@iteriani
refactor(core): Add experimental support to have one event contract w…
3eab29b 
…hen there are multiple apps on the page.

This may be removed if this turns out not to work out so well...
@iteriani iteriani requested review from thePunderWoman and removed request for crisbeto August 12, 2024 21:50
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Aug 12, 2024
thePunderWoman
thePunderWoman approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Aug 13, 2024

This PR was merged into the repository by commit 6882cc7.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
refactor(core): Add experimental support to have one event contract w…
f99bb20 
…hen there are multiple apps on the page. (#57355)

This may be removed if this turns out not to work out so well...

PR Close #57355
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
refactor(core): Add experimental support to have one event contract w…
e30c60e 
…hen there are multiple apps on the page. (#57355)

This may be removed if this turns out not to work out so well...

PR Close #57355
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@iteriani @AndrewKushnir @thePunderWoman