Skip to content

docs(docs-infra): remove hash before link#57351

Closed
vladboisa wants to merge 1 commit intoangular:mainfrom
vladboisa:patch-2
Closed

docs(docs-infra): remove hash before link#57351
vladboisa wants to merge 1 commit intoangular:mainfrom
vladboisa:patch-2

Conversation

@vladboisa
Copy link
Contributor

Remove hash in link for correct view

Fixes #57349

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #57349

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 12, 2024
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fix the issue. @link cannot be used to point to a method.

{@link MyClass#myMethod} should work though.

@vladboisa
Copy link
Contributor Author

This won't fix the issue. @link cannot be used to point to a method.

{@link MyClass#myMethod} should work though.

Done, thank you for a hint!

@github-actions
Copy link

github-actions bot commented Aug 13, 2024

Deployed adev-preview for f084a57 to: https://ng-dev-previews-fw--pr-angular-angular-57351-adev-prev-vzz6jxzy.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Remove hash in link for correct view

Fixes angular#57349

docs(docs-infra): change the link

Change the link with name of class and method

docs: fix the link name
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 18, 2024
@JeanMeche JeanMeche removed the request for review from pkozlowski-opensource August 18, 2024 12:51
@AndrewKushnir AndrewKushnir removed the request for review from pkozlowski-opensource August 29, 2024 14:41
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit cacf2b6.

The changes were merged into the following branches: main, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 29, 2024
Remove hash in link for correct view

Fixes #57349

docs(docs-infra): change the link

Change the link with name of class and method

docs: fix the link name

PR Close #57351
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid link

3 participants