refactor(migrations): handle jit: true component templates in signal input migration#57347
Closed
devversion wants to merge 2 commits intoangular:mainfrom
Closed
refactor(migrations): handle jit: true component templates in signal input migration#57347devversion wants to merge 2 commits intoangular:mainfrom
jit: true component templates in signal input migration#57347devversion wants to merge 2 commits intoangular:mainfrom
Conversation
jit: true component templates in signal input migration
crisbeto
approved these changes
Aug 12, 2024
… migration Instead of exposing just the `ts.CompilerOptions`, we should expose the actual Angular compiler options throuhgout the signal input migration. This will be useful for parsing templates, in cases of JIT-opted components.
…l input migration Components with `jit: true` are not processed by the Angular compiler, so we cannot ask the template checker for the parsed template; simply because the template wasn't attempted to be parsed. We still can migrate simple cases of such components, commonly seen in unit tests. We do this by manually parsing the template and making use of the reference fallback resolution that is also used for host bindings (where we don't have any type check block information).
c116dd4 to
385bfc5
Compare
Contributor
|
This PR was merged into the repository by commit d608b85. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…l input migration (#57347) Components with `jit: true` are not processed by the Angular compiler, so we cannot ask the template checker for the parsed template; simply because the template wasn't attempted to be parsed. We still can migrate simple cases of such components, commonly seen in unit tests. We do this by manually parsing the template and making use of the reference fallback resolution that is also used for host bindings (where we don't have any type check block information). PR Close #57347
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…l input migration (#57347) Components with `jit: true` are not processed by the Angular compiler, so we cannot ask the template checker for the parsed template; simply because the template wasn't attempted to be parsed. We still can migrate simple cases of such components, commonly seen in unit tests. We do this by manually parsing the template and making use of the reference fallback resolution that is also used for host bindings (where we don't have any type check block information). PR Close #57347
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components with
jit: trueare not processed by the Angular compiler,so we cannot ask the template checker for the parsed template; simply
because the template wasn't attempted to be parsed.
We still can migrate simple cases of such components, commonly seen in
unit tests. We do this by manually parsing the template and making use
of the reference fallback resolution that is also used for host bindings
(where we don't have any type check block information).