Skip to content

docs(docs-infra): fix marked rendering#57338

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/marked
Closed

docs(docs-infra): fix marked rendering#57338
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/marked

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 11, 2024

Follow-up to #57319 which introduced some regressions after updating marked to v14

Fixes #57328, #57335, #57336

Note: I'll look into adding tests to prevent those regressions in the future with a follow-up commit.

Follow-up to angular#57319 which introduced some regressions after updating marked to v14
@JeanMeche JeanMeche requested a review from devversion August 11, 2024 23:32
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 11, 2024
@github-actions
Copy link

Deployed adev-preview for 2c9db90 to: https://ng-dev-previews-fw--pr-angular-angular-57338-adev-prev-vgn84dvv.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 12, 2024
@JeanMeche
Copy link
Member Author

JeanMeche commented Aug 12, 2024

Caretaker: This is fine to only merge on main as we're still deploying to the main adev site from the main branch (until we start the v19 changes).

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 360979f.

The changes were merged into the following branches: main

@AndrewKushnir
Copy link
Contributor

@JeanMeche I've merged this PR to the main branch, could you pease create a separate PR for 18.2.x branch (and mark it is as target: rc) if we want to land it in 18.2.0?

@JeanMeche JeanMeche deleted the docs/marked branch August 12, 2024 19:36
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Aug 13, 2024
This is a backport of the marked update and the fix that went with it (angular#57338)
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
This is a backport of the marked update and the fix that went with it (#57338)

PR Close #57363
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Aug 14, 2024
On top of angular#57338, to make sure we prevent similar regressions on marked rendering.
dylhunn pushed a commit that referenced this pull request Aug 19, 2024
On top of #57338, to make sure we prevent similar regressions on marked rendering.

PR Close #57344
dylhunn pushed a commit that referenced this pull request Aug 19, 2024
On top of #57338, to make sure we prevent similar regressions on marked rendering.

PR Close #57344
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raw Markdown visible instead of working links at guide/http

3 participants