fix(core): complete post-hydration cleanup in components that use ViewContainerRef #57300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wContainerRef Previously, if a component injects a `ViewContainerRef`, the post-hydration cleanup process doesn't visit inner views to cleanup dehydrated views in nested LContainers. This commit updates the logic to recognize this situation and enter host LView to complete cleanup. Resolves angular#56989.
thePunderWoman
approved these changes
Aug 8, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
Nice, simple fix! LGTM
Contributor
Author
Contributor
Author
|
This PR was merged into the repository by commit 26ddbdb. The changes were merged into the following branches: main, 18.1.x, 18.2.x |
AndrewKushnir
added a commit
that referenced
this pull request
Aug 9, 2024
…wContainerRef (#57300) Previously, if a component injects a `ViewContainerRef`, the post-hydration cleanup process doesn't visit inner views to cleanup dehydrated views in nested LContainers. This commit updates the logic to recognize this situation and enter host LView to complete cleanup. Resolves #56989. PR Close #57300
AndrewKushnir
added a commit
that referenced
this pull request
Aug 9, 2024
…wContainerRef (#57300) Previously, if a component injects a `ViewContainerRef`, the post-hydration cleanup process doesn't visit inner views to cleanup dehydrated views in nested LContainers. This commit updates the logic to recognize this situation and enter host LView to complete cleanup. Resolves #56989. PR Close #57300
This was referenced Sep 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a component injects a
ViewContainerRef, the post-hydration cleanup process doesn't visit inner views to cleanup dehydrated views in nested LContainers. This commit updates the logic to recognize this situation and enter host LView to complete cleanup.Resolves #56989.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?