Skip to content

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Aug 7, 2024

…t is matched

This commit updates the search results to query for the content as well as a snippet of the content for display when it's the content that matches the query rather than any of the headers.

This commit also de-duplicates matches further by only presenting the search result when the type matched. This means that a match on a lvl1 header, for example, will only include the results for the lvl1 header and not every lvl2 and lvl3 header underneath it as well.

old:
image
image

new:
image
image

@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Aug 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 7, 2024
@github-actions
Copy link

github-actions bot commented Aug 7, 2024

Deployed adev-preview for 4f694ef to: https://ng-dev-previews-fw--pr-angular-angular-57298-adev-prev-stw9vnzy.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@atscott atscott force-pushed the betterResults2 branch 3 times, most recently from 22d0982 to fc45c27 Compare August 8, 2024 14:39
@atscott atscott marked this pull request as ready for review August 8, 2024 15:46
@atscott atscott requested a review from twerske August 8, 2024 18:13
@atscott atscott added the target: patch This PR is targeted for the next patch release label Aug 8, 2024
…t is matched

This commit updates the search results to query for the content as well
as a snippet of the content for display when it's the content that
matches the query rather than any of the headers.
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 6f87dd3.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
…t is matched (#57298)

This commit updates the search results to query for the content as well
as a snippet of the content for display when it's the content that
matches the query rather than any of the headers.

PR Close #57298
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
…t is matched (#57298)

This commit updates the search results to query for the content as well
as a snippet of the content for display when it's the content that
matches the query rather than any of the headers.

PR Close #57298
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants