fix(core): Allow hybrid CD scheduling to support multiple "Angular zo… #57267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f45156b to
2c765d3
Compare
JoostK
reviewed
Aug 6, 2024
packages/core/src/change_detection/scheduling/zoneless_scheduling_impl.ts
Outdated
Show resolved
Hide resolved
2c765d3 to
fb1c077
Compare
alxhub
approved these changes
Aug 6, 2024
fb1c077 to
c10b168
Compare
…nes" This commit updates the inside/outside NgZone detection of the hybrid CD scheduling to track the actual instance of the NgZone being used rather than the name "Angular" (how `isInsideAngularZone` works). This allows the scheduling to work correctly when there are multiple versions of Angular running on the page. fixes angular#57261
c10b168 to
3062051
Compare
Contributor
|
This PR was merged into the repository by commit 769b6e1. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 8, 2024
…nes" (#57267) This commit updates the inside/outside NgZone detection of the hybrid CD scheduling to track the actual instance of the NgZone being used rather than the name "Angular" (how `isInsideAngularZone` works). This allows the scheduling to work correctly when there are multiple versions of Angular running on the page. fixes #57261 PR Close #57267
This was referenced Aug 28, 2024
This was referenced Sep 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nes"
This commit updates the inside/outside NgZone detection of the hybrid CD scheduling to track the actual instance of the NgZone being used rather than the name "Angular" (how
isInsideAngularZoneworks). This allows the scheduling to work correctly when there are multiple versions of Angular running on the page.fixes #57261