docs(router): update initial navigation SSR note #57245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rephrasing by @AndrewKushnir
AndrewKushnir
approved these changes
Aug 6, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@davidlj95 thanks for improving Angular docs!
Contributor
|
Caretaker note: this is docs only and safe to merge without a presubmit. |
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 7, 2024
With rephrasing by @AndrewKushnir PR Close #57245
Contributor
|
This PR was merged into the repository by commit d465061. The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Docs about
enabledBlockingoption for theinitialNavigationrouter's configuration talk about being mandatory for server side rendering (SSR) to work.However, this is no longer configured by Angular CLI in new Angular projects since introducing hydration in v17
Issue Number: N/A
What is the new behavior?
Update recommendation to just use that configuration if hydration isn't configured for users that haven't upgraded to use it yet or aren't using it because of another reason
Docs updated (that could find relate to this):
InitialNavigationenum inprovide_router.tswithEnabledBlockingInitialNavigation()feature method inprovide_router.tsInitialNavigationtype inrouter_config.tsExtraOptionsinterface inrouter_config.tsDoes this PR introduce a breaking change?
Other information
Thought about this by wondering about a StackOverflow question