Skip to content

refactor(docs-infra): migrate api-gen from dev-infra into the repo #57241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josephperrott wants to merge 1 commit into from
Closed

refactor(docs-infra): migrate api-gen from dev-infra into the repo #57241

josephperrott wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Aug 2, 2024

Move the api-gen pipeline into the shared-docs directory

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release PullApprove: disable labels Aug 2, 2024
@josephperrott josephperrott requested a review from JeanMeche August 2, 2024 17:21
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Aug 2, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 2, 2024
@josephperrott josephperrott force-pushed the port-api-gen branch 2 times, most recently from 8d5ad4c to 2d3f732 Compare August 2, 2024 19:06
@josephperrott josephperrott marked this pull request as ready for review August 2, 2024 19:18
@github-actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

Deployed adev-preview for 9242e8a to: https://ng-dev-previews-fw--pr-angular-angular-57241-adev-prev-01fhs48w.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@thePunderWoman
Copy link
Contributor

thePunderWoman commented Aug 5, 2024

@josephperrott looks like this has some conflicts with the new lock files.

@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Aug 5, 2024
@JeanMeche JeanMeche mentioned this pull request Aug 5, 2024
Closed
@josephperrott @JeanMeche
refactor(docs-infra): migrate api-gen from dev-infra into the repo
9242e8a 
Move the api-gen pipeline into the shared-docs directory.
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 5, 2024
@JeanMeche
Copy link
Member

JeanMeche commented Aug 5, 2024

Resolved ✅

@JeanMeche JeanMeche closed this Aug 5, 2024
@JeanMeche JeanMeche reopened this Aug 5, 2024
thePunderWoman pushed a commit that referenced this pull request Aug 5, 2024
@josephperrott @thePunderWoman
refactor(docs-infra): migrate api-gen from dev-infra into the repo (#…
6eac1b3 
…57241)

Move the api-gen pipeline into the shared-docs directory.

PR Close #57241
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Aug 5, 2024

This PR was merged into the repository by commit 3bdead1.

The changes were merged into the following branches: main, 18.1.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 5, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@josephperrott @thePunderWoman @JeanMeche