Skip to content

refactor(docs-infra): Use new APIs in search dialog #57215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

refactor(docs-infra): Use new APIs in search dialog #57215

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jul 31, 2024

This updates the search dialog component to use signal APIs

@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Jul 31, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 31, 2024
@atscott
refactor(docs-infra): Use new APIs in search dialog
7984c11 
This updates the search dialog component to use signal APIs
@github-actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Deployed adev-preview for 7984c11 to: https://ng-dev-previews-fw--pr-angular-angular-57215-adev-prev-qteasf7p.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@atscott atscott marked this pull request as ready for review July 31, 2024 16:04
JeanMeche
JeanMeche approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example of improved readability !

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Jul 31, 2024
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 31, 2024
thePunderWoman pushed a commit that referenced this pull request Jul 31, 2024
@atscott @thePunderWoman
refactor(docs-infra): Use new APIs in search dialog (#57215)
de7f5ac 
This updates the search dialog component to use signal APIs

PR Close #57215
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jul 31, 2024

This PR was merged into the repository by commit f5960d0.

The changes were merged into the following branches: main, 18.1.x

atscott added a commit to atscott/angular that referenced this pull request Aug 5, 2024
@atscott
Revert "refactor(docs-infra): Use new APIs in search dialog (angular#…
c22b07c 
…57215)"

This reverts commit f5960d0.
thePunderWoman pushed a commit that referenced this pull request Aug 5, 2024
@atscott @thePunderWoman
Revert "refactor(docs-infra): Use new APIs in search dialog (#57215)" (…
9109f31 
…#57268)

This reverts commit f5960d0.

PR Close #57268
thePunderWoman pushed a commit that referenced this pull request Aug 5, 2024
@atscott @thePunderWoman
Revert "refactor(docs-infra): Use new APIs in search dialog (#57215)" (…
6b2a4c0 
…#57268)

This reverts commit f5960d0.

PR Close #57268
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 31, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@atscott @thePunderWoman @JeanMeche