refactor(core): Remove clickmod support from Angular. #57201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an old feature that mapped shift + click (et al) to "clickmod". This doesn't really make sense to add to Angular, so let's remove it.
thePunderWoman
approved these changes
Jul 31, 2024
AndrewKushnir
approved these changes
Jul 31, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
tbondwilkinson
approved these changes
Jul 31, 2024
| new EventContractContainer(document.body), | ||
| )); | ||
| const dispatcher = new EventDispatcher(invokeRegisteredListeners); | ||
| const dispatcher = new EventDispatcher(invokeRegisteredListeners, /** clickModSupport */ false); |
Contributor
There was a problem hiding this comment.
/* clickModSupport= */
Contributor
Author
|
TESTED=TGP |
Contributor
|
This PR was merged into the repository by commit 2a915d1. The changes were merged into the following branches: main, 18.1.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 2, 2024
This was an old feature that mapped shift + click (et al) to "clickmod". This doesn't really make sense to add to Angular, so let's remove it. PR Close #57201
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an old feature that mapped shift + click (et al) to "clickmod". This doesn't really make sense to add to Angular, so let's remove it.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information