refactor(core): Update callback schedulers to cancel pending timers#57186
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Update callback schedulers to cancel pending timers#57186atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
Rather than leaving the timers around as no-ops, this commit updates the logic to also attempt to clear or cancel the timers. This is helpful for the eventual goal of running the scheduler in the `fakeAsync` zone (if the test is running in `fakeAsync`) rather than scheduling in the root zone and making it impossible to flush.
4ac7b66 to
5ea3875
Compare
alxhub
approved these changes
Jul 29, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 30, 2024
…57186) Rather than leaving the timers around as no-ops, this commit updates the logic to also attempt to clear or cancel the timers. This is helpful for the eventual goal of running the scheduler in the `fakeAsync` zone (if the test is running in `fakeAsync`) rather than scheduling in the root zone and making it impossible to flush. PR Close #57186
Contributor
|
This PR was merged into the repository by commit b558f99. The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than leaving the timers around as no-ops, this commit updates the logic to also attempt to clear or cancel the timers. This is helpful for the eventual goal of running the scheduler in the
fakeAsynczone (if the test is running infakeAsync) rather than scheduling in the root zone and making it impossible to flush.