Skip to content

refactor(docs-infra): migrate @angular/docs from dev-infra into adev directory#57132

Closed
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:migrate-shared-things-in
Closed

refactor(docs-infra): migrate @angular/docs from dev-infra into adev directory#57132
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:migrate-shared-things-in

Conversation

@josephperrott
Copy link
Member

To increase the ease of development we are moving @angular/docs into the adev directory within this repo. While we are doing this to improve our development experience in the short term, efforts are also in place to maintain a division between this @angular/docs (shared) code and adev itself, so that it can be extracted back out in the future when components is ready to leverage it as well.

@josephperrott josephperrott added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 25, 2024
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Jul 25, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 25, 2024
@josephperrott josephperrott force-pushed the migrate-shared-things-in branch 6 times, most recently from a3a2412 to 2749478 Compare July 25, 2024 17:25
@josephperrott josephperrott force-pushed the migrate-shared-things-in branch 2 times, most recently from 220eaff to 45ac970 Compare July 26, 2024 15:13
@github-actions
Copy link

github-actions bot commented Jul 26, 2024

Deployed adev-preview for 1bd6384 to: https://ng-dev-previews-fw--pr-angular-angular-57132-adev-prev-77bw1cvv.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@josephperrott josephperrott marked this pull request as ready for review July 26, 2024 15:45
@pullapprove pullapprove bot requested review from atscott and devversion July 26, 2024 15:46
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

…directory

To increase the ease of development we are moving @angular/docs into the adev directory within this repo. While
we are doing this to improve our development experience in the short term, efforts are also in place
to maintain a division between this @angular/docs (shared) code and adev itself, so that it can be extracted
back out in the future when components is ready to leverage it as well.
@josephperrott josephperrott force-pushed the migrate-shared-things-in branch from 45ac970 to 1bd6384 Compare July 26, 2024 18:33
@josephperrott josephperrott removed the request for review from devversion July 30, 2024 15:32
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 30, 2024
thePunderWoman pushed a commit that referenced this pull request Jul 30, 2024
…directory (#57132)

To increase the ease of development we are moving @angular/docs into the adev directory within this repo. While
we are doing this to improve our development experience in the short term, efforts are also in place
to maintain a division between this @angular/docs (shared) code and adev itself, so that it can be extracted
back out in the future when components is ready to leverage it as well.

PR Close #57132
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 2d8635d.

The changes were merged into the following branches: main, 18.1.x

@lacolaco
Copy link
Contributor

lacolaco commented Jul 31, 2024

@josephperrott I saw the migrated code and the changes I recently made regarding headings have not been involved and are missing from the dev-infra repository. It is regressing.

https://github.com/angular/angular/blob/main/adev/shared-docs/pipeline/guides/tranformations/heading.ts#L25-L32

https://github.com/angular/dev-infra/blob/29f81ff9fadfa870e9bd0d7507acef4f969e4bfd/docs/pipeline/guides/tranformations/heading.ts#L25-L38

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 31, 2024
@josephperrott josephperrott deleted the migrate-shared-things-in branch May 2, 2025 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants