Skip to content

fix(core): tree shake dev mode error message #57035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): tree shake dev mode error message #57035

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 18, 2024

Adds an ngDevMode check before a runtime error message.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Jul 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 18, 2024
@crisbeto crisbeto force-pushed the 57034/to-signal-error branch from 3e5875e to 55c415b Compare July 18, 2024 09:12
JoostK
JoostK reviewed Jul 18, 2024
View reviewed changes
@crisbeto crisbeto force-pushed the 57034/to-signal-error branch from 55c415b to 9567497 Compare July 18, 2024 09:21
pkozlowski-opensource
pkozlowski-opensource reviewed Jul 18, 2024
View reviewed changes
JeanMeche
JeanMeche reviewed Jul 18, 2024
View reviewed changes
@crisbeto
fix(core): tree shake dev mode error message
bf423ef 
Adds an `ngDevMode` check before a runtime error message.

Fixes angular#57034.
@crisbeto crisbeto force-pushed the 57034/to-signal-error branch from 9567497 to bf423ef Compare July 18, 2024 09:46
pkozlowski-opensource
pkozlowski-opensource reviewed Jul 22, 2024
View reviewed changes
packages/core/rxjs-interop/src/to_signal.ts
case StateKind.NoValue:
// This shouldn't really happen because the error is thrown on creation.
// TODO(alxhub): use a RuntimeError when we finalize the error semantics
throw new ɵRuntimeError(
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sounds like a repeated code - would it make sense to pull it out into a utility function?

Copy link
Member Author

@crisbeto crisbeto Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only repeated code is half of the if statement (kind === StateKind.NoValue)and thethrow new RuntimeError` so I'm not sure it's worth it.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, but I'm not thrilled about having the error message in 2 places.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 22, 2024
@atscott
Copy link
Contributor

atscott commented Jul 22, 2024

This PR was merged into the repository by commit fe41b11.

The changes were merged into the following branches: main, 18.1.x

@atscott atscott closed this in fe41b11 Jul 22, 2024
atscott pushed a commit that referenced this pull request Jul 22, 2024
@crisbeto @atscott
fix(core): tree shake dev mode error message (#57035)
b9fb98c 
Adds an `ngDevMode` check before a runtime error message.

Fixes #57034.

PR Close #57035
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
@crisbeto @vladboisa
fix(core): tree shake dev mode error message (angular#57035)
47a2b5b 
Adds an `ngDevMode` check before a runtime error message.

Fixes angular#57034.

PR Close angular#57035
@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 22, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@JeanMeche JeanMeche JeanMeche left review comments

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @atscott @JoostK @pkozlowski-opensource @JeanMeche