fix(core): Allow zoneless scheduler to run inside fakeAsync #56932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a38c4a3 to
65f39c1
Compare
1285e03 to
573f212
Compare
f8d7020 to
50b4523
Compare
26651bf to
61780c8
Compare
018cfe5 to
7847076
Compare
7847076 to
62c49eb
Compare
62c49eb to
701bb4b
Compare
0d1565d to
0e704f8
Compare
Contributor
|
This PR was merged into the repository by commit 3b0dca7. The changes were merged into the following branches: main, 18.2.x |
dylhunn
pushed a commit
that referenced
this pull request
Aug 15, 2024
The zoneless scheduler callback was executed in the root zone rather than simply in `runOutsideAngular` to allow us to land the hybrid mode change detection (scheduler always enabled, even for zones) without breaking a ton of existing `fakeAsync` tests that could/would fail with the "timer(s) still in queue" error. However, this caused another problem: when a test executes inside `fakeAsync`, it cannot flush the scheduled time. A similar problem exists with event and run coalescing (#56767). This change would allow `fakeAsync` to flush the zoneless-scheduled change detections and minimize breaking existing tests by flushing pending timers at the end of the test, which actually now matches what's done internally. PR Close #56932
This was referenced Aug 28, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zoneless scheduler callback was executed in the root zone rather than simply in
runOutsideAngularto allow us to land the hybrid mode change detection (scheduler always enabled, even for zones) without breaking a ton of existingfakeAsynctests that could/would fail with the "timer(s) still in queue" error. However, this caused another problem: when a test executes insidefakeAsync, it cannot flush the scheduled time. A similar problem exists with event and run coalescing (#56767). This change would allowfakeAsyncto flush the zoneless-scheduled change detections without breaking existingfakeAsynctests that end without flushing pending change detections.