Skip to content

fix(core): toSignal equal option should be passed to inner computed #56903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

fix(core): toSignal equal option should be passed to inner computed #56903

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jul 9, 2024

The user-defined equality function needs to be passed to the inner computed it will still use Object.is and prevent notifications.

@atscott
fix(core): toSignal equal option should be passed to inner computed
06e0a55 
The user-defined equality function needs to be passed to the inner
computed it will still use `Object.is` and prevent notifications.
@atscott atscott added the target: minor This PR is targeted for the next minor release label Jul 9, 2024
@atscott atscott added this to the v18.1 candidates milestone Jul 9, 2024
@atscott atscott requested a review from alxhub July 9, 2024 00:18
@ngbot ngbot bot removed this from the v18.1 candidates milestone Jul 9, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 9, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 9, 2024
@pkozlowski-opensource pkozlowski-opensource self-requested a review July 9, 2024 07:47
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jul 9, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub July 9, 2024 17:49
@pkozlowski-opensource pkozlowski-opensource added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Jul 9, 2024
pkozlowski-opensource pushed a commit that referenced this pull request Jul 9, 2024
@atscott @pkozlowski-opensource
fix(core): toSignal equal option should be passed to inner computed (#…
8bd4c07 
…56903)

The user-defined equality function needs to be passed to the inner
computed it will still use `Object.is` and prevent notifications.

PR Close #56903
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Jul 9, 2024

This PR was merged into the repository by commit 5d75b1d.

The changes were merged into the following branches: main, 18.1.x

@saxenakshitiz saxenakshitiz mentioned this pull request Jul 31, 2024
Closed
@mightysai1997 mightysai1997 mentioned this pull request Jul 31, 2024
Open
@Saptaasur Saptaasur mentioned this pull request Jul 31, 2024
Open
@cvalverd cvalverd mentioned this pull request Aug 1, 2024
Open
@gipo355 gipo355 mentioned this pull request Aug 1, 2024
Open
@SaulReyes-ux SaulReyes-ux mentioned this pull request Aug 1, 2024
Open
@ambrose40 ambrose40 mentioned this pull request Aug 1, 2024
Open
@beyerleinf beyerleinf mentioned this pull request Aug 1, 2024
Open
@sixcorners sixcorners mentioned this pull request Aug 1, 2024
Closed
@surajpuvvada surajpuvvada mentioned this pull request Aug 2, 2024
Closed
@brstlk brstlk mentioned this pull request Aug 2, 2024
Open
@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@amarhusain amarhusain mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 9, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@atscott @pkozlowski-opensource