refactor(core): Allow manual renderer listens to contribute to event …#56799
Closed
iteriani wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Allow manual renderer listens to contribute to event …#56799iteriani wants to merge 1 commit intoangular:mainfrom
iteriani wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
approved these changes
Jul 16, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM on this! Looks like there's some test failures, though.
…delegation as well. There are existing usages that inject the renderer to manualy listen (often for event delegation purposes). These should contribute as well.
Contributor
Author
|
oops done |
Contributor
|
This PR was merged into the repository by commit 3664cd6. The changes were merged into the following branches: main, 18.1.x |
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…delegation as well. (angular#56799) There are existing usages that inject the renderer to manualy listen (often for event delegation purposes). These should contribute as well. PR Close angular#56799
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…delegation as well.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information