Integrate @let into the runtime #56527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
commented
Jun 20, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@crisbeto looks great, just left a few minor comments.
Adds the implementation of the following new instructions: * `declareLet` - creation-time instruction that initializes the slot for a let declaration. * `storeLet` - update-time instruction that stores the current value of a let declaration. * `readContextLet` - instruction that reads the stored value of a let declaration from a different view. On top of the instructions, it also introduces a new `LetDeclaration` TNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support.
Updates the hydration logic to account for the fact that let declarations don't create a DOM node.
Member
Author
|
Thank you for the feedback @AndrewKushnir, it has been addressed. |
AndrewKushnir
approved these changes
Jun 21, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@crisbeto looks great, thanks! 👍
AndrewKushnir
approved these changes
Jun 21, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Jun 24, 2024
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
Contributor
|
This PR was merged into the repository by commit 7dfe302. The changes were merged into the following branches: main, 18.0.x |
dylhunn
pushed a commit
that referenced
this pull request
Jun 26, 2024
Adds the implementation of the following new instructions: * `declareLet` - creation-time instruction that initializes the slot for a let declaration. * `storeLet` - update-time instruction that stores the current value of a let declaration. * `readContextLet` - instruction that reads the stored value of a let declaration from a different view. On top of the instructions, it also introduces a new `LetDeclaration` TNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support. PR Close #56527
dylhunn
pushed a commit
that referenced
this pull request
Jun 26, 2024
Updates the hydration logic to account for the fact that let declarations don't create a DOM node. PR Close #56527
dylhunn
pushed a commit
that referenced
this pull request
Jun 26, 2024
Updates the hydration logic to account for the fact that let declarations don't create a DOM node. PR Close #56527
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes that integrate the new
@letsyntax into the runtime.refactor(core): integrate let instructions into the runtime
Adds the implementation of the following new instructions:
declareLet- creation-time instruction that initializes the slot for a let declaration.storeLet- update-time instruction that stores the current value of a let declaration.readContextLet- instruction that reads the stored value of a let declaration from a different view.On top of the instructions, it also introduces a new
LetDeclarationTNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support.refactor(core): support let declarations during hydration
Updates the hydration logic to account for the fact that let declarations don't create a DOM node.