Skip to content

docs(language-service): Fix quick info URLs#56416

Closed
ViktorTyultinov wants to merge 1 commit intoangular:mainfrom
ViktorTyultinov:docs(language-service)-Fix-quick-info-URLs-to-point-to-Angular-Dev-website
Closed

docs(language-service): Fix quick info URLs#56416
ViktorTyultinov wants to merge 1 commit intoangular:mainfrom
ViktorTyultinov:docs(language-service)-Fix-quick-info-URLs-to-point-to-Angular-Dev-website

Conversation

@ViktorTyultinov
Copy link
Copy Markdown
Contributor

@ViktorTyultinov ViktorTyultinov commented Jun 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #56410

What is the new behavior?

Proper redirection to the new angular website from the quick info

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott June 12, 2024 19:22
@ViktorTyultinov ViktorTyultinov requested a review from atscott June 12, 2024 19:36
@atscott atscott force-pushed the docs(language-service)-Fix-quick-info-URLs-to-point-to-Angular-Dev-website branch from d9de592 to 03cbbd3 Compare June 12, 2024 19:37
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 12, 2024
@JeanMeche
Copy link
Copy Markdown
Member

Can you fix the formatting by running yarn ng-dev format files packages/language-service/src/quick_info_built_ins.ts

@atscott atscott force-pushed the docs(language-service)-Fix-quick-info-URLs-to-point-to-Angular-Dev-website branch from 03cbbd3 to fab5774 Compare June 12, 2024 19:42
@angular-robot angular-robot bot requested a review from atscott June 12, 2024 20:00
@ViktorTyultinov
Copy link
Copy Markdown
Contributor Author

@JeanMeche It should be fine now. Thank you for the guidance!

- Made the links more specific
- Removed the AIO notation
@atscott atscott force-pushed the docs(language-service)-Fix-quick-info-URLs-to-point-to-Angular-Dev-website branch from faef2a1 to c59432c Compare June 12, 2024 20:18
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit c698668.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 13, 2024
- Made the links more specific
- Removed the AIO notation

PR Close #56416
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants