refactor(core): Add and move tests for Dispatcher.#56193
Closed
tbondwilkinson wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Add and move tests for Dispatcher.#56193tbondwilkinson wants to merge 1 commit intoangular:mainfrom
Dispatcher.#56193tbondwilkinson wants to merge 1 commit intoangular:mainfrom
Conversation
Move tests from `eventcontract_test.ts` to `dispatcher_test.ts` for functionality that lives in `Dispatcher`. Add an extra test for `preventDefault` behavior for `CLICKMOD` that covers a previous bug case.
Contributor
Author
|
TESTED=No TGP required as this are Angular test changes only. |
thePunderWoman
approved these changes
May 31, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-core, primitives
thePunderWoman
pushed a commit
that referenced
this pull request
Jun 4, 2024
Move tests from `eventcontract_test.ts` to `dispatcher_test.ts` for functionality that lives in `Dispatcher`. Add an extra test for `preventDefault` behavior for `CLICKMOD` that covers a previous bug case. PR Close #56193
Contributor
|
This PR was merged into the repository by commit a65c1cf. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tests from
eventcontract_test.tstodispatcher_test.tsforfunctionality that lives in
Dispatcher.Add an extra test for
preventDefaultbehavior forCLICKMODthatcovers a previous bug case.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?