Skip to content

refactor(core): remove doubled line#56091

Closed
lor3k wants to merge 1 commit intoangular:mainfrom
lor3k:lor3k-patch-1
Closed

refactor(core): remove doubled line#56091
lor3k wants to merge 1 commit intoangular:mainfrom
lor3k:lor3k-patch-1

Conversation

@lor3k
Copy link
Contributor

@lor3k lor3k commented May 27, 2024

Removed doubled line

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Doubled line with pipe titlecase
Issue Number: N/A

What is the new behavior?

Removed doubled line

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented May 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from devversion May 27, 2024 07:32
@pkozlowski-opensource pkozlowski-opensource added the area: migrations Issues related to `ng update`/`ng generate` migrations label May 27, 2024
@ngbot ngbot bot added this to the Backlog milestone May 27, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from devversion May 27, 2024 09:33
@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 27, 2024
@pullapprove pullapprove bot requested a review from devversion May 27, 2024 09:33
@pkozlowski-opensource pkozlowski-opensource added the target: patch This PR is targeted for the next patch release label May 27, 2024
@pkozlowski-opensource
Copy link
Member

@lor3k thnx for the PR - it looks good, but will require some book keeping before the merge (see failing status checks):

  • you need to sign the CLA
  • commit message should be updated to follow our guidelines

@lor3k lor3k changed the title Removed doubled line fix(core): remove doubled line May 27, 2024
@JeanMeche
Copy link
Member

JeanMeche commented May 28, 2024

Could you make it a refactor(core) ... commit ?
We probably don't want this one to appear in the change log as a fix.

Thank you.

remove doubled line of titlecase pipe in commonModulePipes array
@lor3k lor3k changed the title fix(core): remove doubled line refactor(core): remove doubled line May 29, 2024
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 29, 2024
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 31, 2024
thePunderWoman pushed a commit that referenced this pull request May 31, 2024
remove doubled line of titlecase pipe in commonModulePipes array

PR Close #56091
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 9d034f6.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants