Skip to content

fix(language-service): use type-only import in plugin factory#55996

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:language-service-fix-2
Closed

fix(language-service): use type-only import in plugin factory#55996
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:language-service-fix-2

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Fixes that the plugin factory was causing TypeScript to be bundled into the language service.

Fixes that the plugin factory was causing TypeScript to be bundled into the language service.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 22, 2024
@crisbeto crisbeto requested a review from dylhunn May 22, 2024 16:19
@pullapprove pullapprove bot requested a review from atscott May 22, 2024 16:19
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2024
@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented May 22, 2024

This PR was merged into the repository by commit d17e6a5.

@dylhunn dylhunn closed this in d17e6a5 May 22, 2024
dylhunn pushed a commit that referenced this pull request May 22, 2024
Fixes that the plugin factory was causing TypeScript to be bundled into the language service.

PR Close #55996
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants