Skip to content

refactor(core): remove unused preventDefault on listener#55879

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/wrapWithPreventDefault
Closed

refactor(core): remove unused preventDefault on listener#55879
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/wrapWithPreventDefault

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 19, 2024

wrapListener was only invoked with wrapWithPreventDefault set to false.

The usage with true was removed by #46646.

`wrapListener` was only invoked with `wrapWithPreventDefault` set to `false`.
@JeanMeche JeanMeche marked this pull request as ready for review May 19, 2024 21:09
@pullapprove pullapprove bot requested a review from alxhub May 19, 2024 21:09
@dylhunn dylhunn removed the request for review from alxhub May 22, 2024 22:27
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: core Issues related to the framework runtime labels May 22, 2024
@ngbot ngbot bot added this to the Backlog milestone May 22, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 22, 2024

This PR was merged into the repository by commit a0690fe.

dylhunn pushed a commit that referenced this pull request May 22, 2024
`wrapListener` was only invoked with `wrapWithPreventDefault` set to `false`.

PR Close #55879
@dylhunn dylhunn closed this in a0690fe May 22, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants