Skip to content

fix(compiler): optimize track function that only passes $index#55872

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:track-by-index-optimization
Closed

fix(compiler): optimize track function that only passes $index#55872
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:track-by-index-optimization

Conversation

@crisbeto
Copy link
Member

Currently we optimize methods that pass both $index and the item into a method. We can take this a step further by also optimizing calls that only pass $index into the first parameter.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 19, 2024
@crisbeto crisbeto requested a review from dylhunn May 19, 2024 08:28
Currently we optimize methods that pass both `$index` and the item into a method. We can take this a step further by also optimizing calls that only pass `$index` into the first parameter.
@crisbeto crisbeto force-pushed the track-by-index-optimization branch from bf4d330 to e27c97f Compare May 19, 2024 17:30
@dylhunn dylhunn added the area: compiler Issues related to `ngc`, Angular's template compiler label May 22, 2024
@ngbot ngbot bot added this to the Backlog milestone May 22, 2024
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 22, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 6aeea69.

pkozlowski-opensource pushed a commit that referenced this pull request May 23, 2024
Currently we optimize methods that pass both `$index` and the item into a method. We can take this a step further by also optimizing calls that only pass `$index` into the first parameter.

PR Close #55872
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants