Skip to content

refactor(core): Add a bit to EventInfo to mark resolution.#55864

Closed
tbondwilkinson wants to merge 1 commit intoangular:mainfrom
tbondwilkinson:jsaction-resolved
Closed

refactor(core): Add a bit to EventInfo to mark resolution.#55864
tbondwilkinson wants to merge 1 commit intoangular:mainfrom
tbondwilkinson:jsaction-resolved

Conversation

@tbondwilkinson
Copy link
Contributor

This will prevent running ActionResolver logic multiple times while migrating to use Dispatcher to resolve actions rather than EventContract.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

This will prevent running `ActionResolver` logic multiple times while
migrating to use `Dispatcher` to resolve actions rather than
`EventContract`.
@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson marked this pull request as ready for review May 20, 2024 16:17
@tbondwilkinson tbondwilkinson requested review from iteriani and removed request for alxhub, atscott, dylhunn and neonstalwart May 20, 2024 16:17
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 20, 2024
@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate core: event dispatch labels May 20, 2024
@ngbot ngbot bot added this to the Backlog milestone May 20, 2024
@pullapprove pullapprove bot requested a review from alxhub May 20, 2024 16:41
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@tbondwilkinson tbondwilkinson removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 21, 2024
@tbondwilkinson tbondwilkinson added the action: merge The PR is ready for merge by the caretaker label May 21, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit bb13174.

@dylhunn dylhunn closed this in bb13174 May 21, 2024
dylhunn pushed a commit that referenced this pull request May 21, 2024
This will prevent running `ActionResolver` logic multiple times while
migrating to use `Dispatcher` to resolve actions rather than
`EventContract`.

PR Close #55864
@tbondwilkinson tbondwilkinson deleted the jsaction-resolved branch June 10, 2024 23:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants