Skip to content

refactor(core): Update error for both zone and zoneless to be only fo…#55813

Closed
atscott wants to merge 1 commit intoangular:mainfrom
atscott:invalidcdconfigonlyforapps
Closed

refactor(core): Update error for both zone and zoneless to be only fo…#55813
atscott wants to merge 1 commit intoangular:mainfrom
atscott:invalidcdconfigonlyforapps

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented May 15, 2024

…r apps

Developers may want to enable zoneless for all tests by default by adding the zoneless provider to initTestEnvironment and then temporarily disabling it for individual tests with the zone provider until they can be made zoneless compatible.

@atscott atscott added the target: rc This PR is targeted for the next release-candidate label May 15, 2024
@atscott atscott requested a review from andrewseguin May 15, 2024 16:36
@atscott atscott added the area: core Issues related to the framework runtime label May 15, 2024
@ngbot ngbot bot added this to the Backlog milestone May 15, 2024
@atscott atscott force-pushed the invalidcdconfigonlyforapps branch 3 times, most recently from f9dd072 to 994349e Compare May 15, 2024 17:17
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label May 15, 2024
@atscott atscott force-pushed the invalidcdconfigonlyforapps branch from 994349e to 78a8273 Compare May 15, 2024 18:12
…r apps

Developers may want to enable zoneless for all tests by default by
adding the zoneless provider to `initTestEnvironment` and then
temporarily disabling it for individual tests with the zone provider
until they can be made zoneless compatible.
@atscott atscott force-pushed the invalidcdconfigonlyforapps branch from 78a8273 to 10c8626 Compare May 15, 2024 18:15
@atscott
Copy link
Contributor Author

atscott commented May 15, 2024

This PR was merged into the repository by commit 84b2351.

atscott added a commit that referenced this pull request May 15, 2024
…r apps (#55813)

Developers may want to enable zoneless for all tests by default by
adding the zoneless provider to `initTestEnvironment` and then
temporarily disabling it for individual tests with the zone provider
until they can be made zoneless compatible.

PR Close #55813
@atscott atscott closed this in 84b2351 May 15, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants