fix(compiler): prevent usage of reserved control flow @ symbol in custom interpolation context for better parser failure#55809
Closed
bougwal wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
…m interpolation context. * Fixes the issue where using a reserved control flow @ symbol in a custom interpolation context yields improper parser feedback.
7599e90 to
63b2524
Compare
devversion
approved these changes
May 15, 2024
Member
|
Given that the interpolation config is now deprecated, I'm not sure if we'd want to do this. cc @alxhub |
Member
|
I was under impression it would be a temporary improvement that makes the situation more clear. |
Author
|
Hi Paul @devversion and Kristiyan @crisbeto , I opened the PR after Alex's confirmation here: #55772 (comment) |
crisbeto
approved these changes
May 15, 2024
Member
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, I hadn't seen this discussion.
Contributor
|
This PR was merged into the repository by commit 2bb12ac. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.