refactor(core): Refactor out constants to be used in jsaction. Also, don't do anymore jsaction work after event replay is done.#55799
Closed
iteriani wants to merge 8 commits intoangular:mainfrom
Closed
refactor(core): Refactor out constants to be used in jsaction. Also, don't do anymore jsaction work after event replay is done.#55799iteriani wants to merge 8 commits intoangular:mainfrom
iteriani wants to merge 8 commits intoangular:mainfrom
Conversation
38624da to
f725ee4
Compare
…hing is replayed. Without this, I think subsequent renders will populate data structures.
…ptured, or are mouse events. Use these constants across jsaction and Angular.
…zed, captured, or are mouse events.
…zed, captured, or are mouse events.
tbondwilkinson
approved these changes
May 15, 2024
…zed, captured, or are mouse events.
…zed, captured, or are mouse events.
AndrewKushnir
approved these changes
May 17, 2024
| ]); | ||
|
|
||
| /** | ||
| * A default set of events that clients should use to install the event contract. |
Contributor
There was a problem hiding this comment.
Suggested change
| * A default set of events that clients should use to install the event contract. | |
| * Detects whether a given event type is supported by JSAction. |
AndrewKushnir
approved these changes
May 17, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
thePunderWoman
approved these changes
May 20, 2024
…zed, captured, or are mouse events.
Contributor
Author
|
TESTED=TGP |
AndrewKushnir
approved these changes
May 22, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@iteriani LGTM 👍
There was a tiny comment related to docs: https://github.com/angular/angular/pull/55799/files#r1603875571, but we can address it in a separate PR if it'd be easier.
…zed, captured, or are mouse events.
Member
|
caretaker note: pending code reviews status got "stuck", ignoring pending reviews |
Member
|
This PR was merged into the repository by commit 690b0fb. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information