Revert "fix(core): render hooks should not specifically run outside t…#55624
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
Revert "fix(core): render hooks should not specifically run outside t…#55624atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
…he Angular zone (angular#55399)" This reverts commit 7e89753. Running render hooks inside the zone is specifically problematic for `afterRender` hooks. If the callback has async task, it would cause an infinite change detection. In addition, updating state in render hooks is generally discourages and certainly should update state in a way that notifies Angular of the change (either via signal or with `markForCheck`) rather than relying on ZoneJS to pick it up (which would only work if the change is done inside an async task).
alxhub
approved these changes
May 1, 2024
Contributor
Author
|
merge assistance: g3 failures are unrelated |
Contributor
|
This PR was merged into the repository by commit 8cabb7a. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2024
…he Angular zone (#55399)" (#55624) This reverts commit 7e89753. Running render hooks inside the zone is specifically problematic for `afterRender` hooks. If the callback has async task, it would cause an infinite change detection. In addition, updating state in render hooks is generally discourages and certainly should update state in a way that notifies Angular of the change (either via signal or with `markForCheck`) rather than relying on ZoneJS to pick it up (which would only work if the change is done inside an async task). PR Close #55624
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2024
…he Angular zone (#55399)" (#55624) This reverts commit 7e89753. Running render hooks inside the zone is specifically problematic for `afterRender` hooks. If the callback has async task, it would cause an infinite change detection. In addition, updating state in render hooks is generally discourages and certainly should update state in a way that notifies Angular of the change (either via signal or with `markForCheck`) rather than relying on ZoneJS to pick it up (which would only work if the change is done inside an async task). PR Close #55624
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he Angular zone (#55399)"
This reverts commit 7e89753.
Running render hooks inside the zone is specifically problematic for
afterRenderhooks. If the callback has async task, it would cause an infinite change detection. In addition, updating state in render hooks is generally discourages and certainly should update state in a way that notifies Angular of the change (either via signal or withmarkForCheck) rather than relying on ZoneJS to pick it up (which would only work if the change is done inside an async task).