fix(core): added @angular/compiler as a peer dependency#55610
fix(core): added @angular/compiler as a peer dependency#55610emilrowland wants to merge 2 commits intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, one NIT.
For context, @angular/compiler is required by @angular/core/testing
This fixes an issue with packages managers likes pmpm that will not link the @angular/compiler package to the @angular/core package if it is not listed as a peer dependency. I added it as optional peer dependency as it's only used in special cases. Fixes #38096
|
This PR was merged into the repository by commit 7eb59d3. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This fixes an issue with packages managers likes pmpm that will not link the @angular/compiler package to the @angular/core package if it is not listed as a peer dependency.
I added it as optional peer dependency as it's only used in special cases.
Fixes #38096
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Today @angular/core/testing is using @angular/compiler without specifying it as a dependency.
This results in strict package managers like pnpm don't find the dependency.
Issue Number: #38096
What is the new behavior?
@angular/compiler is added as an optional peerDependency for @angular/core
Does this PR introduce a breaking change?
Other information