test(core): fix expectations that accidentally used incorrect matchers#55294
Closed
leonsenft wants to merge 1 commit intoangular:mainfrom
Closed
test(core): fix expectations that accidentally used incorrect matchers#55294leonsenft wants to merge 1 commit intoangular:mainfrom
leonsenft wants to merge 1 commit intoangular:mainfrom
Conversation
alxhub
approved these changes
Apr 10, 2024
pkozlowski-opensource
approved these changes
Apr 11, 2024
Expect that the number of template executions is `===` to a number, rather than expect that it does not contain a number. As they were, these expectations would pass regardless of the expected value.
4ee93dd to
bb73158
Compare
Contributor
Author
|
Fixed the existing formatting issue that prevented submission. |
pkozlowski-opensource
approved these changes
Apr 12, 2024
Member
|
This PR was merged into the repository by commit f2f2c2a. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 16, 2024
angular#55294) Expect that the number of template executions is `===` to a number, rather than expect that it does not contain a number. As they were, these expectations would pass regardless of the expected value. PR Close angular#55294
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expect that the number of template executions is
===to a number, rather than expect that it does not contain a number. As they were, these expectations would pass regardless of the expected value.