Skip to content

refactor(language-service): add a plugin factory initialize helper#55264

Closed
clydin wants to merge 1 commit intoangular:mainfrom
clydin:ls/plugin-factory-init
Closed

refactor(language-service): add a plugin factory initialize helper#55264
clydin wants to merge 1 commit intoangular:mainfrom
clydin:ls/plugin-factory-init

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Apr 9, 2024

An implementation of a TypeScript server plugin module factory has been added to the main plugin code which minimizes the amount of infrastructure code necessary to directly setup the Angular plugin. This is not yet used externally but can be integrated in the future.

@clydin clydin added area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Apr 9, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 9, 2024
An implementation of a TypeScript server plugin module factory has
been added to the main plugin code which minimizes the amount of
infrastructure code necessary to directly setup the Angular plugin.
This is not yet used externally but can be integrated in the future.
@clydin clydin force-pushed the ls/plugin-factory-init branch from a7d09a8 to 7d0b416 Compare April 9, 2024 16:19
@clydin clydin requested a review from atscott April 9, 2024 18:00
@clydin clydin marked this pull request as ready for review April 9, 2024 18:00
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 9, 2024
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2024
@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 5c29416.

@clydin clydin deleted the ls/plugin-factory-init branch April 12, 2024 16:59
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 16, 2024
…ngular#55264)

An implementation of a TypeScript server plugin module factory has
been added to the main plugin code which minimizes the amount of
infrastructure code necessary to directly setup the Angular plugin.
This is not yet used externally but can be integrated in the future.

PR Close angular#55264
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants