fix(migrations): account for variables in imports initializer#55081
fix(migrations): account for variables in imports initializer#55081crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Fixes that the control flow migration was throwing an error if the `imports` of a component are initialized to an identifier. Fixes angular#55080.
| `const BEFORE = [];\n`, | ||
| `const AFTER = [];\n`, | ||
| `@Component({`, | ||
| ` imports: [...BEFORE, ...AFTER],`, |
There was a problem hiding this comment.
Oh, I wonder if it is safe to remove the CommonModule here - what happens if someone uses non-control-flow dependencies from that module? Are we verifying this case?
There was a problem hiding this comment.
@jessicajaniuk should know more about it, I just took one of the existing tests and tweaked it to cover the case from #55080.
There was a problem hiding this comment.
Yeah we are already looking at symbols used from common module in the component file and the template. So we do know if it's safe to remove at this point.
There was a problem hiding this comment.
Awesome, thnx for confirming @jessicajaniuk !
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this!
| `const BEFORE = [];\n`, | ||
| `const AFTER = [];\n`, | ||
| `@Component({`, | ||
| ` imports: [...BEFORE, ...AFTER],`, |
There was a problem hiding this comment.
Yeah we are already looking at symbols used from common module in the component file and the template. So we do know if it's safe to remove at this point.
|
This PR was merged into the repository by commit 6368871. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that the control flow migration was throwing an error if the
importsof a component are initialized to an identifier.Fixes #55080.