Skip to content

refactor(compiler): add support for the new search element#54945

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:refactor/search-element
Closed

refactor(compiler): add support for the new search element#54945
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:refactor/search-element

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 19, 2024

@JeanMeche JeanMeche force-pushed the refactor/search-element branch 2 times, most recently from 91e8715 to 5e8e57c Compare March 19, 2024 13:57
@JeanMeche JeanMeche marked this pull request as ready for review March 23, 2024 16:05
jelbourn
jelbourn approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@dylhunn dylhunn added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2024
alxhub
alxhub approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: fw-security

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 29, 2024
atscott pushed a commit that referenced this pull request Mar 29, 2024
@JeanMeche @atscott
refactor(compiler): add support for the new search element (#54945)
a8a20ad 
See #whatwg/html#5811
Spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-search-element

fixes #54944

PR Close #54945
@atscott
Copy link
Contributor

atscott commented Mar 29, 2024

This PR was merged into the repository by commit 367b3ee.

@atscott atscott closed this in 367b3ee Mar 29, 2024
atscott added a commit to atscott/angular that referenced this pull request Mar 29, 2024
@atscott
Revert "refactor(compiler): add support for the new search element (a…
9b442af 
…ngular#54945)"

This reverts commit 367b3ee.
The search element is not a void element but existing components may use
the same selector and be used as a void element.
@atscott atscott reopened this Mar 29, 2024
@atscott atscott added state: blocked requires: TGP This PR requires a passing TGP before merging is allowed and removed action: merge The PR is ready for merge by the caretaker labels Mar 29, 2024
@atscott
Copy link
Contributor

atscott commented Mar 29, 2024

Adding blocked and TGP label. This broke internal builds because the native search is not a void element but existing components with the same selector might be used in templates as void elements.

atscott added a commit that referenced this pull request Mar 29, 2024
@atscott
Revert "refactor(compiler): add support for the new search element (#…
d10dc5c 
…54945)" (#55127)

This reverts commit 367b3ee.
The search element is not a void element but existing components may use
the same selector and be used as a void element.

PR Close #55127
atscott added a commit that referenced this pull request Mar 29, 2024
@atscott
Revert "refactor(compiler): add support for the new search element (#…
38bb95a 
…54945)" (#55127)

This reverts commit 367b3ee.
The search element is not a void element but existing components may use
the same selector and be used as a void element.

PR Close #55127
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 10, 2024
@JeanMeche JeanMeche closed this May 22, 2024
@JeanMeche JeanMeche force-pushed the refactor/search-element branch from 5e8e57c to 85c1719 Compare May 22, 2024 23:26
@angular-robot angular-robot bot requested a review from atscott May 22, 2024 23:26
@JeanMeche JeanMeche reopened this May 22, 2024
@pullapprove pullapprove bot removed the request for review from atscott October 21, 2024 22:57
@the-ult
Copy link

the-ult commented Dec 11, 2024

Is this gonna be added?
PR has been open for a long time

@JeanMeche
Copy link
Member Author

JeanMeche commented Dec 11, 2024

@the-ult unfortunately this is a breaking change as it collides with exisisting components/directives with the search selector. This can only land when the breaking change window is open (for v20).

@the-ult
Copy link

the-ult commented Dec 11, 2024

@the-ult unfortunately this is a breaking change as it collides with exisisting components/directives with the search selector. This can only land when the breaking change window is open (for v20).

so we just missed the window with Angular 19.
New change in a few months :-)

@JeanMeche JeanMeche mentioned this pull request Feb 11, 2025
Closed
@JeanMeche JeanMeche force-pushed the refactor/search-element branch 5 times, most recently from e438836 to 9f36d44 Compare April 9, 2025 16:41
@JeanMeche
refactor(compiler): add support for the new search element
c3b5747 
See #whatwg/html#5811
Spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-search-element

breaking change: You cannot have self-closing `search` component anymore as they are recognized as a native non-void element.

fixes angular#54944
@JeanMeche JeanMeche force-pushed the refactor/search-element branch from 9f36d44 to c3b5747 Compare April 9, 2025 18:46
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Apr 9, 2025
@JeanMeche
Copy link
Member Author

JeanMeche commented Apr 11, 2025 •
edited
Loading

Caretaker note: Presubmit & TGP are green, breakage is unrelated

@JeanMeche JeanMeche added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 11, 2025
@kirjs
Copy link
Contributor

kirjs commented Apr 14, 2025

This PR was merged into the repository by commit 84d359c.

The changes were merged into the following branches: main, 19.2.x

kirjs pushed a commit that referenced this pull request Apr 14, 2025
@JeanMeche @kirjs
refactor(compiler): add support for the new search element (#54945)
c0e4ff1 
See #whatwg/html#5811
Spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-search-element

breaking change: You cannot have self-closing `search` component anymore as they are recognized as a native non-void element.

fixes #54944

PR Close #54945
@kirjs kirjs closed this in 84d359c Apr 14, 2025
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 15, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@alxhub alxhub alxhub approved these changes

+1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

v20 candidates

Development

Successfully merging this pull request may close these issues.

7 participants

@JeanMeche @atscott @the-ult @kirjs @jelbourn @alxhub @dylhunn