refactor(core): add internal API to enable i18n hydration#54784
Closed
devknoll wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): add internal API to enable i18n hydration#54784devknoll wants to merge 1 commit intoangular:mainfrom
devknoll wants to merge 1 commit intoangular:mainfrom
Conversation
devknoll
commented
Mar 8, 2024
971dde2 to
f95d3d8
Compare
AndrewKushnir
approved these changes
Mar 9, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@devknoll looks great, just one nit related to a function name.
f95d3d8 to
2ec2874
Compare
AndrewKushnir
approved these changes
Mar 9, 2024
2ec2874 to
7fbf651
Compare
Contributor
7fbf651 to
fd003bd
Compare
Contributor
|
@devknoll FYI I've pushed a rebase to get the branch to the most up-to-date state (the branch was created at the time when CI was "red" for unrelated reasons), but the |
Contributor
Author
|
Looks likely to be similar to the timing/ordering issues I ran into in #54823. I'll push an improved fix to this branch in the morning for you to review. Thanks for the flag 👍 |
fd003bd to
01b7429
Compare
Add an internal API to enable and use i18n hydration for testing and development. This helps ensure that we don't accidentally break the current behavior until we are completely ready to roll out i18n support.
01b7429 to
9173666
Compare
AndrewKushnir
approved these changes
Mar 12, 2024
Contributor
Contributor
|
Caretaker note: presubmit is "green", this PR is ready for merge. |
atscott
pushed a commit
that referenced
this pull request
Mar 12, 2024
Add an internal API to enable and use i18n hydration for testing and development. This helps ensure that we don't accidentally break the current behavior until we are completely ready to roll out i18n support. PR Close #54784
Contributor
|
This PR was merged into the repository by commit 456f18b. |
atscott
pushed a commit
that referenced
this pull request
Mar 12, 2024
Add an internal API to enable and use i18n hydration for testing and development. This helps ensure that we don't accidentally break the current behavior until we are completely ready to roll out i18n support. PR Close #54784
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
henry-alakazhang
pushed a commit
to freelancer/angular
that referenced
this pull request
Jun 19, 2024
) Add an internal API to enable and use i18n hydration for testing and development. This helps ensure that we don't accidentally break the current behavior until we are completely ready to roll out i18n support. PR Close angular#54784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an internal API to enable and use i18n hydration for testing and development. This helps ensure that we don't accidentally break the current behavior until we are completely ready to roll out i18n support.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information