perf(core): speed up retrieval of DestroyRef in EventEmitter#54748
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
perf(core): speed up retrieval of DestroyRef in EventEmitter#54748devversion wants to merge 1 commit intoangular:mainfrom
DestroyRef in EventEmitter#54748devversion wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
reviewed
Mar 7, 2024
pkozlowski-opensource
approved these changes
Mar 7, 2024
6cf75f5 to
919c864
Compare
crisbeto
approved these changes
Mar 7, 2024
Member
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, one non-blocking comment
919c864 to
87dc868
Compare
Member
Author
alxhub
previously requested changes
Mar 9, 2024
Speeds up the retrieval of `DestroyRef` in `EventEmitter` because `try/catch` is expensive if there is no injection context. We saw a script time regression in Cloud. The goldens had to be updated because `getInjectImplementation` is now referenced. `inject` also references the underlying field, but directly. This is super minimal overhead of a function exposing the internal field.
87dc868 to
78c0418
Compare
Member
Author
|
Caretaker note: Pre-existing failures— fixed via #54791 |
Contributor
|
This PR was merged into the repository by commit 142825d. |
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
) Speeds up the retrieval of `DestroyRef` in `EventEmitter` because `try/catch` is expensive if there is no injection context. We saw a script time regression in Cloud. The goldens had to be updated because `getInjectImplementation` is now referenced. `inject` also references the underlying field, but directly. This is super minimal overhead of a function exposing the internal field. PR Close #54748
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up the retrieval of
DestroyRefinEventEmitterbecausetry/catchis expensive ifthere is no injection context.
We saw a script time regression in Cloud.