fix(core): apply TestBed provider overrides to @defer dependencies#54667
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): apply TestBed provider overrides to @defer dependencies#54667AndrewKushnir wants to merge 1 commit intoangular:mainfrom
@defer dependencies#54667AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
This commit updates TestBed logic to take into account situations when dependencies loaded within `@defer` blocks may import NgModules with providers. For such components, we invoke provider override function, which recursively inspects and applies the necessary changes.
f372e53 to
8adcfb6
Compare
Contributor
Author
Member
|
This PR was merged into the repository by commit 33a6fab. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates TestBed logic to take into account situations when dependencies loaded within
@deferblocks may import NgModules with providers. For such components, we invoke provider override function, which recursively inspects and applies the necessary changes.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?