Skip to content

fix(shared-docs): remove unwanted styling on API page.#54621

Closed
JeanMeche wants to merge 4 commits intoangular:mainfrom
JeanMeche:fix/api-flickering
Closed

fix(shared-docs): remove unwanted styling on API page.#54621
JeanMeche wants to merge 4 commits intoangular:mainfrom
JeanMeche:fix/api-flickering

Conversation

@JeanMeche
Copy link
Member

@angular-robot angular-robot bot added the area: docs Related to the documentation label Feb 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 28, 2024
@github-actions
Copy link

github-actions bot commented Feb 28, 2024

Deployed adev-preview for 99aff1f to: https://ng-dev-previews-fw--pr-angular-angular-54621-adev-prev-76ie5i34.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche marked this pull request as ready for review February 28, 2024 20:57
@pullapprove pullapprove bot requested a review from crisbeto February 28, 2024 20:57
@JeanMeche JeanMeche force-pushed the fix/api-flickering branch from 591303a to 99aff1f Compare March 2, 2024 18:55
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 2, 2024
@JeanMeche JeanMeche requested review from josephperrott and removed request for crisbeto March 2, 2024 18:56
@pullapprove pullapprove bot requested a review from crisbeto March 2, 2024 18:56
Copy link
Contributor

@twerske twerske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twerske twerske added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2024
@twerske
Copy link
Contributor

twerske commented Mar 4, 2024

Marking for merge - the CI failure looks false?

@pkozlowski-opensource pkozlowski-opensource added the target: patch This PR is targeted for the next patch release label Mar 5, 2024
@pkozlowski-opensource
Copy link
Member

@twerske yeh, the red CI was a flake - but this PR needs more reviews before it gets in

Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit d2ec5b6.

pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
Remove the unecessary double quotes on a @see link.

PR Close #54621
pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
`box-sizing: border-box` prevents overflow caused by borders.

PR Close #54621
pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
Remove the unecessary double quotes on a @see link.

PR Close #54621
pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flickering when changing API tabs

4 participants