fix(migrations): Fix cf migration regular expression to include underscores#54533
Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): Fix cf migration regular expression to include underscores#54533jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Conversation
e651c1c to
4354700
Compare
…scores In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration. fixes: angular#54532
4354700 to
577fa46
Compare
AndrewKushnir
approved these changes
Feb 20, 2024
crisbeto
approved these changes
Feb 21, 2024
|
|
||
| writeFile('/comp.html', [ | ||
| `<div *ngIf="show">show</div>`, | ||
| `<a-very-long-component-name-that-has_underscores-too`, |
Member
|
This PR was merged into the repository by commit 42d3ddd. |
Member
|
@stefhorst if you run into problems with 17.2.2 please open a dedicated issue with a minimal reproduction scenario. You are commenting on a PR that has nothing to do with routing. |
|
OK sorry |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?