fix(compiler-cli): use correct symbol name for default imported symbo…#54495
Closed
JoostK wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): use correct symbol name for default imported symbo…#54495JoostK wants to merge 1 commit intoangular:mainfrom
JoostK wants to merge 1 commit intoangular:mainfrom
Conversation
…ls in defer blocks This commit addresses a problem with PR angular#53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes angular#54491
f97e3a1 to
da14b1d
Compare
Member
|
This PR was merged into the repository by commit 0c8744c. |
alxhub
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ls in defer blocks (#54495) This commit addresses a problem with PR #53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes #54491 PR Close #54495
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ls in defer blocks
This commit addresses a problem with PR #53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of
.defaultfor the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for theɵsetClassMetadataAsyncfunction, but not the generated dependency loader function.Fixes #54491