refactor(compiler-cli): avoid naming conflict with built-in global variable#54333
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler-cli): avoid naming conflict with built-in global variable#54333crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…riable The import of `module` can conflict with the native global variable called `module` and can break some internal tests. These switch to only importing the function we need.
devversion
approved these changes
Feb 8, 2024
Member
|
Note: That default imports are necessary/better for the ESM/CJS interop, but I think it works here because in ESM, NodeJS will expose |
Contributor
|
This PR was merged into the repository by commit 9c2bad9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import of
modulecan conflict with the native global variable calledmoduleand can break some internal tests. These switch to only importing the function we need.