Skip to content

refactor(compiler-cli): work around internal test failure#54327

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:fatal-diagnostic-proto
Closed

refactor(compiler-cli): work around internal test failure#54327
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:fatal-diagnostic-proto

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2024

Fixes an internal test failure due to FatalDiagnosticError extending the native Error.

Fixes an internal test failure due to `FatalDiagnosticError` extending the native `Error`.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Feb 7, 2024
@ngbot ngbot bot modified the milestone: Backlog Feb 7, 2024
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 7, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 8, 2024
Fixes an internal test failure due to `FatalDiagnosticError` extending the native `Error`.

PR Close #54327
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 44f65f2.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants