Skip to content

refactor: migrate common to prettier formatting#54150

Closed
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:move-common-to-prettier
Closed

refactor: migrate common to prettier formatting#54150
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:move-common-to-prettier

Conversation

@josephperrott
Copy link
Copy Markdown
Member

Migrate formatting to prettier for common from clang-format

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 29, 2024
@josephperrott josephperrott force-pushed the move-common-to-prettier branch from de9a8be to c5b1039 Compare January 29, 2024 21:54
@jessicajaniuk
Copy link
Copy Markdown
Contributor

@josephperrott Looks like this can't be merged into 17.1.x.

@josephperrott josephperrott force-pushed the move-common-to-prettier branch from c5b1039 to 8ce7f01 Compare January 30, 2024 14:13
@josephperrott josephperrott added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 30, 2024
@josephperrott josephperrott force-pushed the move-common-to-prettier branch from 8ce7f01 to 5819577 Compare January 30, 2024 14:16
@jessicajaniuk
Copy link
Copy Markdown
Contributor

@josephperrott Looks like this now has file conflicts. Let me know when that's resolved, and I'll land these before anything else to prevent further conflicts.

Migrate formatting to prettier for common from clang-format
@josephperrott josephperrott force-pushed the move-common-to-prettier branch from 5819577 to 7a72cd3 Compare January 30, 2024 15:09
@jessicajaniuk jessicajaniuk added the area: core Issues related to the framework runtime label Jan 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 30, 2024
@jessicajaniuk jessicajaniuk added PullApprove: disable merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 30, 2024
@jessicajaniuk
Copy link
Copy Markdown
Contributor

Caretaker: No need for additional reviews as this is just formatting changes.

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 0460a9d.

@josephperrott josephperrott deleted the move-common-to-prettier branch January 30, 2024 17:29
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
Migrate formatting to prettier for common from clang-format

PR Close angular#54150
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants