docs: remove ngx-deploy-npm from deployers table#53999
Closed
dianjuar wants to merge 1 commit intoangular:mainfrom
Closed
docs: remove ngx-deploy-npm from deployers table#53999dianjuar wants to merge 1 commit intoangular:mainfrom
dianjuar wants to merge 1 commit intoangular:mainfrom
Conversation
dgp1130
approved these changes
Jan 23, 2024
dgp1130
requested changes
Jan 23, 2024
Contributor
dgp1130
left a comment
There was a problem hiding this comment.
Oh I think we would also want to update angular.dev which has a similar table here:
Contributor
Author
|
@dgp1130 Changes requested applied |
dgp1130
approved these changes
Jan 24, 2024
alan-agius4
approved these changes
Jan 25, 2024
Contributor
|
Caretaker note: current approvals should suffice |
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jan 25, 2024
This package will no longer support Angular CLI workspaces in the next major version. Instead they will soley support NX. See: https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn and angular/angular#53999
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Jan 25, 2024
This package will no longer support Angular CLI workspaces in the next major version. Instead they will soley support NX. See: https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn and angular/angular#53999
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Jan 25, 2024
This package will no longer support Angular CLI workspaces in the next major version. Instead they will soley support NX. See: https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn and angular/angular#53999 (cherry picked from commit 7717dba)
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 25, 2024
Contributor
|
This PR was merged into the repository by commit bd9c2c5. |
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
In the deployment documentation, there is a listed tool that no longer offers support for Angular.
What is the new behavior?
Remove the deployer
ngx-deploy-npmfrom the documentation since it will no longer work for Angular workspaces.Does this PR introduce a breaking change?
Other information
More information can be found on ngx-deploy-npm blog post about version 8, where the maintainers announced the removal of Angular workspace support.