refactor(compiler): enable register and resolve phases for local compilation#53901
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler): enable register and resolve phases for local compilation#53901AndrewKushnir wants to merge 1 commit intoangular:mainfrom
register and resolve phases for local compilation#53901AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
14 tasks
pmvald
reviewed
Jan 12, 2024
packages/compiler-cli/src/ngtsc/transform/test/compilation_spec.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/test/compilation_spec.ts
Outdated
Show resolved
Hide resolved
4d9e2cb to
bff3f24
Compare
Contributor
Author
|
@pmvald thanks for the feedback! I've updated PR to address all comments, please take another look when you get a chance. Thank you. |
resolve phase for local compilationregister and resolve phases for local compilation
bff3f24 to
cd44e18
Compare
3 tasks
pmvald
approved these changes
Jan 16, 2024
Contributor
Author
…compilation This commit update the logic to enable `register` and `resolve` phases for local compilation. Those phases will be useful for local compilation in certain cases (will be used in followup PRs).
cd44e18 to
d4ca690
Compare
alxhub
approved these changes
Jan 17, 2024
Contributor
Author
|
Caretaker note: the presubmit is "green", this PR is ready for merge. |
Contributor
|
This PR was merged into the repository by commit 08233b8. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…compilation (angular#53901) This commit update the logic to enable `register` and `resolve` phases for local compilation. Those phases will be useful for local compilation in certain cases (will be used in followup PRs). PR Close angular#53901
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…compilation (angular#53901) This commit update the logic to enable `register` and `resolve` phases for local compilation. Those phases will be useful for local compilation in certain cases (will be used in followup PRs). PR Close angular#53901
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…compilation (angular#53901) This commit update the logic to enable `register` and `resolve` phases for local compilation. Those phases will be useful for local compilation in certain cases (will be used in followup PRs). PR Close angular#53901
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…compilation (angular#53901) This commit update the logic to enable `register` and `resolve` phases for local compilation. Those phases will be useful for local compilation in certain cases (will be used in followup PRs). PR Close angular#53901
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit update the logic to enable
resolvephase for local compilation. Theresolvephase will be useful for local compilation in certain cases (will be used in followup PRs).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?