refactor(core): Pending effects should make the application unstable#53835
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Pending effects should make the application unstable#53835atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
atscott
commented
Jan 8, 2024
715d4bd to
a35cd42
Compare
a35cd42 to
88e51c5
Compare
88e51c5 to
7e44f5d
Compare
alxhub
approved these changes
Feb 23, 2024
Member
|
Looks like this one needs a rebase |
7e44f5d to
a53334a
Compare
Member
|
Thnx for rebase @atscott! It seems like it trigger some legit test failures, though, so flipping it back to cleanup. |
In zone-full applications, this is already true because effects are scheduled inside a microtask and tracked by ZoneJS. When not using zones, this should stay consistent on principle and for testability reasons. A general pattern with zoneless testing will be to update state and `await` some promise (i.e. `fixture.whenStable`, which will be linked to `ApplicationRef.isStable`).
a53334a to
1114c3c
Compare
Member
|
This PR was merged into the repository by commit 07173fd. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 4, 2024
…53835) In zone-full applications, this is already true because effects are scheduled inside a microtask and tracked by ZoneJS. When not using zones, this should stay consistent on principle and for testability reasons. A general pattern with zoneless testing will be to update state and `await` some promise (i.e. `fixture.whenStable`, which will be linked to `ApplicationRef.isStable`). PR Close #53835
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In zone-full applications, this is already true because effects are scheduled inside a microtask and tracked by ZoneJS. When not using zones, this should stay consistent on principle and for testability reasons. A general pattern with zoneless testing will be to update state and
awaitsome promise (i.e.fixture.whenStable, which will be linked toApplicationRef.isStable).